pass --gc-sections if -Zexport-executable-symbols is enabled and improve tests #143846
+40
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-run-make
usamoi
commented
Jul 12, 2025
| } | ||
| cmd.gc_sections(keep_metadata); | ||
| } else { | ||
| cmd.no_gc_sections(); |
There was a problem hiding this comment.
The removed line is the only place in rustc where no_gc_sections is called, so I had to call it here to suppress the unused warning.
rustbot
added
S-waiting-on-review
|
This PR modifies cc @jieyouxu Some changes occurred in compiler/rustc_codegen_ssa |
|
Maybe r? @bjorn3 (or reroll) |
jieyouxu
reviewed
Jul 13, 2025
| .invalid_stdout_utf8(); | ||
| assert_contains(&output, "exported_symbol"); | ||
| } else { | ||
| let output = llvm_readobj().symbols().input(bin_name("main")).run().invalid_stdout_utf8(); |
There was a problem hiding this comment.
Discussion: Hm, this might not be quite right for windows msvc, cc @ChrisDenton ?
There was a problem hiding this comment.
llvm-readobj indeed cannot read symbols from MSVC-generated artifacts. I just switched to using the object crate to read the exports.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exported symbols are added as GC roots in linking, so
--gc-sectionswon't hurt-Zexport-executable-symbols.Fixes the run-make test to work on Linux. Enable the ui test on more targets.
cc #84161